pipenv: Ignore additional pipenv output #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipenv can print additional output that would end up in our variables, e. g., if a `.env` file exists, `python-shell-virtualenv-root` ends up as `Loading .env environment variables...\n/home/user/.local/share/virtualenvs/project`. This change is to: a) call pipenv with `--quiet`, so that it does not print extra information in the first place; b) pass `'(t nil)` as `buffer` argument to `process-file`, so that it ignores stderr and the buffer only contains stdout. Signed-off-by: Thomas Schneider <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipenv can print additional output that would end up in our variables, e. g., if a
.envfile exists,python-shell-virtualenv-rootends up asLoading .env environment variables...\n/home/user/.local/share/virtualenvs/project.This change is to:
--quiet, so that it does not print extra information in the first place;'(t nil)asbufferargument toprocess-file, so that it ignores stderr and the buffer only contains stdout.This issue may also exist with other backends, I did not check those. On a side note, it would be cool if one could supply arbitrary backends, instead of hard-ish-coding everything in
pet-virtualenv-root, but that’s probably a significant rewrite and a different issue.